[v8] RFC-0045: Stack management by simonjjones · Pull Request #3687 · cloudfoundry/cli

simonjjones · 2026-01-20T15:18:52Z

Thank you for contributing to the CF CLI! Please read the following:

Please make sure you have implemented changes in line with the contributing guidelines
We're not allowed to accept any PRs without a signed CLA, no matter how small.
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
All new code requires tests to protect against regressions.
Contributions must be made against the appropriate branch. See the contributing guidelines
Contributions must conform to our style guide. Please reach out to us if you have questions.

Note: Please create separate PR for every branch (main and v8) as needed.

Description of the Change

This PR covers the CLI implementation details for RFC-0045: Enhance Stack Handling in Cloud Foundry. It adds an additional state field to output of the cf stack, cf stacks & cf update-stack commands, as well as adding the ability to modify the state to the cf update-stack command. This is a partner PR to the existing Cloud Controller changes submitted for review

Why Is This PR Valuable?

These changes will be required for consumers to interact with the new features available in the Cloud Controller, the RFC has been accepted, indicating the changes are valuable.

Applicable Issues

N/A

How Urgent Is The Change?

This should be accepted and released in line with the changes being proposed to the Cloud Controller

Other Relevant Parties

The Cloud Controller changes linked above should detail other people impacted.

Signed-off-by: Simon Jones <simonjones@vmware.com>

vuil

Thanks for the changes. I added a couple of minor suggestions. I assume this needs to wait till the cloud-controller changes are merged?

command/v7/stack_command_test.go

rashedkvm

Just a reminder to update the minimum API version prior to merging. Much appreciated!

vuil

There were some recent CI fixes that should move the integ tests along now.

Changes looks good to me. My comments are mostly minor indentation issues (probably also present in #3688 as well)

vuil · 2026-02-04T23:45:30Z

command/common/internal/help_all_display.go

-			{"env", "set-env", "unset-env"},
-			{"stacks", "stack"},
-			{"copy-source", "create-app-manifest"},
+		{"env", "set-env", "unset-env"},


nit: fix indent?

vuil · 2026-02-04T23:52:03Z

command/v7/stack_command_test.go

+				fakeActor.GetStackByNameReturns(stack, v7action.Warnings{}, nil)
+			})
+
+			It("Displays the stack information without state", func() {


Thanks for addressing the comments here.
nit: it's odd I am not seeing the issue on the github page, but when I checked out the branch, it is showing this It("Displays... block is misindented by one fewer level. Same is true the next It(Displays.. block

vuil · 2026-02-05T00:01:39Z

command/v7/update_stack_command_test.go

+	Context("when state values are provided in different cases", func() {
+		It("accepts 'active' and capitalizes it", func() {
+			cmd.State = "active"
+			fakeActor.GetStackByNameReturns(resources.Stack{GUID: "guid"}, v7action.Warnings{}, nil)
+			fakeActor.UpdateStackReturns(resources.Stack{Name: "some-stack", State: resources.StackStateActive}, v7action.Warnings{}, nil)
+
+			executeErr = cmd.Execute(args)
+
+			Expect(executeErr).ToNot(HaveOccurred())
+			_, state := fakeActor.UpdateStackArgsForCall(0)
+			Expect(state).To(Equal(resources.StackStateActive))
+		})
+
+		It("accepts 'RESTRICTED' and keeps it capitalized", func() {
+			cmd.State = "RESTRICTED"
+			fakeActor.GetStackByNameReturns(resources.Stack{GUID: "guid"}, v7action.Warnings{}, nil)
+			fakeActor.UpdateStackReturns(resources.Stack{Name: "some-stack", State: resources.StackStateRestricted}, v7action.Warnings{}, nil)
+
+			executeErr = cmd.Execute(args)
+
+			Expect(executeErr).ToNot(HaveOccurred())
+			_, state := fakeActor.UpdateStackArgsForCall(0)
+			Expect(state).To(Equal(resources.StackStateRestricted))
+		})
+
+		It("accepts 'Disabled' and capitalizes it", func() {
+			cmd.State = "Disabled"
+			fakeActor.GetStackByNameReturns(resources.Stack{GUID: "guid"}, v7action.Warnings{}, nil)
+			fakeActor.UpdateStackReturns(resources.Stack{Name: "some-stack", State: resources.StackStateDisabled}, v7action.Warnings{}, nil)
+
+			executeErr = cmd.Execute(args)
+
+			Expect(executeErr).ToNot(HaveOccurred())
+			_, state := fakeActor.UpdateStackArgsForCall(0)
+			Expect(state).To(Equal(resources.StackStateDisabled))
+		})
+	})


Nit: did you mean to have this block be a child context of "Context("When the environment is setup correctly" ? Probably doesn't matter either way but if it is meant to be, then its indent is a little off.

vuil · 2026-02-05T00:05:40Z

resources/stack_resource.go

+}
+
+// ValidStackStatesString returns a pipe-separated string of valid states in lowercase
+func ValidStackStatesString() string {


nit: Unused code?

simonjjones added 7 commits December 1, 2025 14:38

Add state field to cf stacks command

8657670

Signed-off-by: Simon Jones <simonjones@vmware.com>

Remove state validation from cf state command

ca7c432

Signed-off-by: Simon Jones <simonjones@vmware.com>

Add state output to cf stacks command

fcc41cd

Signed-off-by: Simon Jones <simonjones@vmware.com>

first pass of update-stack command

3516b13

Signed-off-by: Simon Jones <simonjones@vmware.com>

Include reference to state in help text for cf stack & stacks

b29d390

Signed-off-by: Simon Jones <simonjones@vmware.com>

Add update stack command integration tests

c4e4734

Signed-off-by: Simon Jones <simonjones@vmware.com>

Stack related fakes generated correctly by counterfeiter

0ddeb16

Signed-off-by: Simon Jones <simonjones@vmware.com>

rashedkvm mentioned this pull request Jan 20, 2026

[RFC0045] Enhance Stack Handling in Cloud Foundry cloudfoundry/community#1331

Open

4 tasks

Merge branch 'v8' into v8-stack-management

cd08e31

simonjjones mentioned this pull request Jan 20, 2026

[main] RFC-0045: Stack management #3688

Open

Add update-stack to help categories in APPS section

6df05cc

simonjjones marked this pull request as draft January 21, 2026 17:17

Add parentheses and spaces to update-stack usage command

64ec3ed

Signed-off-by: Simon Jones <simonjones@vmware.com>

simonjjones marked this pull request as ready for review January 28, 2026 16:38

vuil reviewed Jan 29, 2026

View reviewed changes

command/v7/stack_command_test.go Show resolved Hide resolved

command/v7/stack_command_test.go Show resolved Hide resolved

rashedkvm reviewed Jan 29, 2026

View reviewed changes

simonjjones and others added 3 commits January 30, 2026 12:09

Add minimum API version check for update-stack command (3.210.0)

e44f012

Add assertions for state output in stack command tests

b6ba7fa

Merge branch 'v8' into v8-stack-management

91633b1

anujc25 changed the title ~~V8 stack management~~ [v8] RFC-0045: Stack management Feb 4, 2026

Merge branch 'v8' into v8-stack-management

4be6183

vuil reviewed Feb 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v8] RFC-0045: Stack management#3687

[v8] RFC-0045: Stack management#3687
simonjjones wants to merge 14 commits intocloudfoundry:v8from
simonjjones:v8-stack-management

simonjjones commented Jan 20, 2026

Uh oh!

vuil left a comment

Uh oh!

Uh oh!

Uh oh!

rashedkvm left a comment

Uh oh!

vuil left a comment

Uh oh!

vuil Feb 4, 2026

Uh oh!

vuil Feb 4, 2026 •

edited

Loading

Uh oh!

vuil Feb 5, 2026 •

edited

Loading

Uh oh!

vuil Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

simonjjones commented Jan 20, 2026

Note: Please create separate PR for every branch (main and v8) as needed.

Description of the Change

Why Is This PR Valuable?

Applicable Issues

How Urgent Is The Change?

Other Relevant Parties

Uh oh!

vuil left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rashedkvm left a comment

Choose a reason for hiding this comment

Uh oh!

vuil left a comment

Choose a reason for hiding this comment

Uh oh!

vuil Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

vuil Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vuil Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vuil Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vuil Feb 4, 2026 •

edited

Loading

vuil Feb 5, 2026 •

edited

Loading